Differences

This shows you the differences between two versions of the page.

--- courses:cs335:spring2013:voluntary_associations:home [2013/05/12 14:14] – [Development Statistics] admin
+++ courses:cs335:spring2013:voluntary_associations:home [2013/05/14 21:33] – [More issues I found] admin
@@ Line 34: / Line 34: @@
 ===== Preliminary Implementation Feedback =====
-  *
+  * Good job on the preliminary implementation
+    * Figured out many issues, questions for client
+  * Learned about an implicit requirement (didn't come out earlier) -- adding a new inscription; good that you already have a good start to the implementation of that requirement
+  * Seems like you know the next steps, and they are relatively straightforward, with the possible exception of the mapping part (which is the really cool part)
+==== Suggestions/TODO ====
+  * To make DB set up easier, put all DB set up into one file, e.g., reading the parameters from web.xml and setting up a ''BasicDataSource'' in a ''ServletContextListener''.
+    * Using this approach, the creation of the DB is the responsibility of one class (not several classes) and it's easier to change the DB location
+  * Make sure all the pages that you do //not// want a user to directly access (e.g., responses to Servlets) are in the ''WEB-INF'' directory
+  * Move code into appropriate packages (e.g., ''collegium.servlets'') -- don't use the default package
+  * We discussed some other suggestions during the meeting (e.g., the revised header; only showing part of the longer inscriptions' texts, passing the trunk test, etc.)
+    * add an about page -- about the project and about the developers -- include your names, links to your home pages, etc.
+    * if appropriate, add a page about the code you have used from others
+  * I think the label should be "Transcription" rather than "Original Text".  Like we talked about in class, I don't think that's necessarily the original text but rather what people think the text is meant to say.
+===== Suggestions during Lightning Talk =====
+  * Advanced search -- allow more than one option to be selected
+  * Search through the text?
+===== More issues Sprenkle found =====
+I added some more data to the inscriptions so that they're more populated.
+  * In what order are the inscriptions displayed?  I thought it was inscription id order, but it doesn't appear to be that.
+  * Where is the date field coming from?  I edited inscription with hd_number='HD000718' with it's correct date (which I got from the EDH), and the date didn't show up on the search results page or the detailed inscriptions page.
+  * It doesn't seem like the deities are showing up (e.g., for inscription 187)